Fixes and some cleanup in the python tools #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This piece of code is a library and it is not good for a library to care about catching CTRL-C. This should be done in the application (if needed). In fact this feature prevented integrating this code with PyQT4.
Otherwise it is imported instead of the "serial" package on case-insensitive filesystems.
The call to self.cancel() sets isDone to True.
The busy waiting loop drained quickly the laptop battery. It is more user-friendly to detect and report if a device has been disconnected (also freeing up the resources).
|
This seems impressive, and it's great that you reviewed the usually neglected python sdk. (the issues you linked are not related, that's a completely different sdk see the discussion in #259 - I think the best would be to rewrite the deluge tools and just drop the tos.py) |
|
lets merge |
|
merge On Wed, Apr 1, 2015 at 9:52 AM, gnawali [email protected] wrote:
Eric B. Decker |
andrasbiro
added a commit
that referenced
this pull request
Apr 7, 2015
Fixes and some cleanup in the python tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several problems with the TinyOS Python tools.
The code has been tested under high load on MacOS X (Maverics) and Debian GNU/Linux 7.8 .