Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

[do not merge] Slack vitess v11.0.4.vtctld.pre #247

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vmogilev
Copy link
Member

@vmogilev vmogilev commented May 23, 2022

Description

This will serve as the base branch for 11.x vtctld branches, and should not be merged into master.

I compiled a list of cherry picks you see below from the following PRs:

as PER: https://paper.dropbox.com/doc/Deploys--BiBeEroaHSASXm33RaJsy5GMAg-4DTMhk7UnGtetj5tqzJ75#:h2=But-where-do-the-cherry-picks-

and started to apply them to this branch using:

git cherry-pick -m1 {pr-merge-sha}

all cherry picks with [x] are done, the rest still need to be applied manually. It's a very tedious process due to many (and I mean MANY conflicts that need to be resolved manually). There are also a number of proto conflicts on generated files which I attempted to fix as follows:

make install_protoc-gen-go
make proto

From #231:

From #232

From #233

From TBD...

This is the section that still needs to be compiled as per:

any new vtctld changes since the last deploy
REF: https://paper.dropbox.com/doc/Deploys--BiBeEroaHSASXm33RaJsy5GMAg-4DTMhk7UnGtetj5tqzJ75#:h2=But-where-do-the-cherry-picks-

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

rafael and others added 2 commits May 23, 2022 13:06
…funcs_to_topotools

[wrangler|topotools] Migrate `UpdateShardRecords`, `RefreshTabletsByShard`, and `{Get,Save}RoutingRules`

Signed-off-by: Vitaliy Mogilevskiy <[email protected]>
…vschemas

[vtctld] Add GetSrvVSchemas command

Signed-off-by: Vitaliy Mogilevskiy <[email protected]>
@vmogilev vmogilev requested a review from doeg as a code owner May 23, 2022 23:14
@vmogilev vmogilev requested a review from ameetkotian May 23, 2022 23:15
ajm188 and others added 3 commits June 6, 2022 15:10
add backup status to vtctld 9.0 branch

Signed-off-by: Vitaliy Mogilevskiy <[email protected]>
…t_conns

[grpctmclient] Add support for (bounded) per-host connection reuse
Fix for padding in OrderAndCheckPartitions
@vmogilev
Copy link
Member Author

vmogilev commented Jun 8, 2022

re-running failed jobs:
Screen Shot 2022-06-08 at 12 32 55 PM

@vmogilev
Copy link
Member Author

vmogilev commented Jun 8, 2022

re-running one more failed test:

Screen Shot 2022-06-08 at 2 58 06 PM

@vmogilev
Copy link
Member Author

vmogilev commented Jun 9, 2022

[17:04] ~/nobackup/dev/vt/ts/vitess (slack-vitess-v11.0.4.vtctld.pre) $ git tag -am 'v11.0.4.vtctld.rc1' slack-vitess-v11.0.4.vtctld.rc1 && git push --tags tinyspeck
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 185 bytes | 185.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:tinyspeck/vitess
 * [new tag]               slack-vitess-v11.0.4.vtctld.rc1 -> slack-vitess-v11.0.4.vtctld.rc1
[17:04] ~/nobackup/dev/vt/ts/vitess (slack-vitess-v11.0.4.vtctld.pre) $

@vmogilev
Copy link
Member Author

vmogilev commented Jun 9, 2022

@vmogilev vmogilev removed the request for review from doeg June 9, 2022 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants