Full CMake Integration : Forward properly linker flags, CFLAGS, CXXFLAGS, support statically linked libstdc++ and unit + integration tests support for Corrosion on top of master #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each target we add a ctest target to run unit tests and we register newly the cargo integration tests as part of the build. examples and doctests are not supported yet but could be added in a similar fashion. # Conflicts: # cmake/CorrosionGenerator.cmake
5 tasks
…FLAGS,CXXFLAGS
This also manages CMAKE_POSITION_INDEPENDENT_CODE for Rust targets and generally
supports the use case of setting a custom stdlib= and linking it statically
by appropriate flags in CMAKE_CXX_FLAGS and CMAKE_EXE_LINKER_FLAGS.
As for example :
```
set(CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS} -stdlib=libc++ ")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld")
set (CMAKE_POSITION_INDEPENDENT_CODE ON)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld -stdlib=libc++ -static-libstdc++ -static-libgcc /usr/local/share/.tipi/clang/4f846ee/lib/libc++.a /usr/local/sþhare/.tipi/clang/4f846ee/lib/libc++abi.a")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++ -static-libgcc /usr/local/share/.tipi/clang/4f846ee/lib/libc++.a /usr/local/share/.tipi/clang/4f846ee/lib/libc++abi.a")
```
daminetreg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆕 Properly control the rust targets native ffi builds for CXXSTDLIB,CFLAGS,CXXFLAGS
This also manages CMAKE_POSITION_INDEPENDENT_CODE for Rust targets and generally
supports the use case of setting a custom stdlib= and linking it statically
by appropriate flags in CMAKE_CXX_FLAGS and CMAKE_EXE_LINKER_FLAGS.
As for example :
Also this adds the changes of #1 but on top of master as I needed fixes from the master branch that has a tad better but still very early install support.
For each target we add a ctest target to run unit tests and we register newly the cargo integration tests as part of the build.
examples and doctests are not supported yet but could be added in a similar fashion later on.