perf: improve log, comment some unused logs

tisfeng · Apr 22, 2024 · 27a71da · 27a71da
1 parent bfe7747
commit 27a71da
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 14 deletions.
diff --git a/Easydict/Swift/Service/Ali/AliService.swift b/Easydict/Swift/Service/Ali/AliService.swift
@@ -241,7 +241,6 @@ class AliService: QueryService {
                     if let data = value.data, let translateText = data.translated {
                         result.translatedResults = [translateText]
                         completion(result, nil)
-                        logInfo("ali api translate success")
                     } else {
                         completion(
                             result,
@@ -257,7 +256,7 @@ class AliService: QueryService {
                         msg = error.errorDescription
                     }
 
-                    logError("ali api translate error: \(msg ?? "")")
+                    logError("Ali translate error: \(msg ?? "")")
                     completion(result, EZError(nsError: error, errorDataMessage: msg))
                 }
             }

diff --git a/Easydict/Swift/Service/Gemini/GeminiService.swift b/Easydict/Swift/Service/Gemini/GeminiService.swift
@@ -55,7 +55,7 @@ public final class GeminiService: QueryService {
             do {
                 let prompt = GeminiService
                     .translationPrompt + "Translate the following \(from.rawValue) text into \(to.rawValue): \(text)"
-                logInfo("gemini prompt: \(prompt)")
+//                logInfo("gemini prompt: \(prompt)")
                 let model = GenerativeModel(
                     name: "gemini-pro",
                     apiKey: apiKey,

diff --git a/Easydict/objc/Service/Apple/AppleDictionary/EZAppleDictionary.m b/Easydict/objc/Service/Apple/AppleDictionary/EZAppleDictionary.m
@@ -254,7 +254,7 @@ - (nullable NSString *)queryAllIframeHTMLResultOfWord:(NSString *)word
 - (NSArray<NSString *> *)queryEntryHTMLsOfWord:(NSString *)word 
                                   inDictionary:(TTTDictionary *)dictionary
                                       language:(nullable EZLanguage)language {
-    CFAbsoluteTime startTime = CFAbsoluteTimeGetCurrent();
+//    CFAbsoluteTime startTime = CFAbsoluteTimeGetCurrent();
     NSMutableArray *entryHTMLs = [NSMutableArray array];
 
     // Cost about ~10ms
@@ -270,8 +270,8 @@ - (nullable NSString *)queryAllIframeHTMLResultOfWord:(NSString *)word
         }
     }
 
-    CFAbsoluteTime endTime = CFAbsoluteTimeGetCurrent();
-    MMLogInfo(@"Query [%@] dict cost: %.1f ms", dictionary.name, (endTime - startTime) * 1000); // 13ms
+//    CFAbsoluteTime endTime = CFAbsoluteTimeGetCurrent();
+//    MMLog(@"Query [%@] dict cost: %.1f ms", dictionary.name, (endTime - startTime) * 1000); // 13ms
 
     return entryHTMLs;
 }

diff --git a/Easydict/objc/Service/Apple/AppleDictionary/apple-dictionary.html b/Easydict/objc/Service/Apple/AppleDictionary/apple-dictionary.html
@@ -444,7 +444,7 @@
     // Change font size
     function changeIframeBodyFontSize(fontSizeRatio) {
       var percentFontSize = fontSizeRatio * 100 + "%";
-      console.log("fontSize: " + fontSizeRatio);
+      // console.log("fontSize: " + fontSizeRatio);
 
       // change body font size
       document.body.style.fontSize = percentFontSize;
@@ -514,4 +514,4 @@
 
 <body></body>
 
-</html>
+</html>
diff --git a/Easydict/objc/Service/WebViewTranslator/EZWebViewTranslator.m b/Easydict/objc/Service/WebViewTranslator/EZWebViewTranslator.m
@@ -316,7 +316,7 @@ - (void)webView:(WKWebView *)webView didFailProvisionalNavigation:(WKNavigation
 // 监听 JavaScript 代码是否执行
 - (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(void))completionHandler {
     // JavaScript 代码执行
-    MMLogError(@"runJavaScriptAlertPanelWithMessage: %@", message);
+    MMLogInfo(@"runJavaScriptAlertPanelWithMessage: %@", message);
 }
 
 

diff --git a/Easydict/objc/ViewController/View/WordResultView/EZWordResultView.m b/Easydict/objc/ViewController/View/WordResultView/EZWordResultView.m
@@ -1010,7 +1010,7 @@ - (BOOL)textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector
 #pragma mark - WKNavigationDelegate
 
 - (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation {
-    MMLogInfo(@"webView didFinishNavigation");
+//    MMLog(@"webView didFinishNavigation");
 
     [self.result.webViewManager updateAllIframe];
 }
@@ -1093,7 +1093,7 @@ - (void)updateWebViewHeight:(CGFloat)scrollHeight {
     // Cost ~0.15s
     //    NSString *script = @"document.documentElement.scrollHeight;";
 
-    MMLogInfo(@"scrollHeight: %.1f", scrollHeight);
+//    MMLog(@"scrollHeight: %.1f", scrollHeight);
 
     CGFloat visibleFrameHeight = EZLayoutManager.shared.screen.visibleFrame.size.height;
     CGFloat maxHeight = visibleFrameHeight * 0.55;

diff --git a/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m b/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
@@ -1516,12 +1516,11 @@ - (void)autoPlayEnglishWordAudio {
     }
 
     BOOL isEnglishWord = [self.queryText isEnglishWordWithLanguage:self.queryModel.queryFromLanguage];
-
     if (!isEnglishWord) {
-        MMLogWarn(@"Not an English Word");
         return;
     }
 
+    MMLogInfo(@"Auto play English word audio: %@", self.queryText);
     [self togglePlayQueryText:YES];
 }
 

diff --git a/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryWindow.m b/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryWindow.m
@@ -128,7 +128,7 @@ - (void)windowDidResignKey:(NSNotification *)notification {
 }
 
 - (void)windowDidResize:(NSNotification *)aNotification {
-    MMLogInfo(@"windowDidResize: %@, windowType: %ld", @(self.frame), self.windowType);
+//    MMLog(@"windowDidResize: %@, windowType: %ld", @(self.frame), self.windowType);
 
     [[EZLayoutManager shared] updateWindowFrame:self];