perf(UI): adjust kVerticalPadding from 8 to 6

tisfeng · Dec 2, 2023 · 646a160 · 646a160
1 parent 152d488
commit 646a160
Showing 1 changed file with 18 additions and 17 deletions.
diff --git a/Easydict/Feature/ViewController/View/WordResultView/EZWordResultView.m b/Easydict/Feature/ViewController/View/WordResultView/EZWordResultView.m
@@ -33,7 +33,8 @@
 
 static const CGFloat kHorizontalMargin_8 = 8;
 static const CGFloat kVerticalMargin_12 = 12;
-static const CGFloat kVerticalPadding_8 = 8;
+static const CGFloat kVerticalPadding_6 = 6;
+static const CGFloat kBlueTextButtonVerticalPadding_3 = 3;
 
 static NSString *const kAppleDictionaryURIScheme = @"x-dictionary";
 
@@ -297,10 +298,10 @@ - (void)refreshWithResult:(EZQueryResult *)result {
                     height += kVerticalMargin_12;
                 } else {
                     make.top.offset(kHorizontalMargin_8);
-                    height += kVerticalPadding_8;
+                    height += kVerticalPadding_6;
                 }
             } else {
-                CGFloat topOffset = kVerticalPadding_8;
+                CGFloat topOffset = kVerticalPadding_6;
                 make.top.equalTo(lastView.mas_bottom).offset(topOffset);
                 height += topOffset;
             }
@@ -466,7 +467,7 @@ - (void)refreshWithResult:(EZQueryResult *)result {
                 exceptedWidth += kHorizontalMargin_8;
 
                 if (lastView) {
-                    CGFloat topOffset = kVerticalPadding_8;
+                    CGFloat topOffset = kVerticalPadding_6;
                     if (idx == 0) {
                         topOffset = kVerticalMargin_12;
                     }
@@ -505,7 +506,7 @@ - (void)refreshWithResult:(EZQueryResult *)result {
                 exceptedWidth += kHorizontalMargin_8;
 
                 if (lastView) {
-                    CGFloat topPadding = kVerticalPadding_8;
+                    CGFloat topPadding = kVerticalPadding_6;
                     if (idx == 0) {
                         topPadding = kVerticalMargin_12;
                     }
@@ -514,7 +515,7 @@ - (void)refreshWithResult:(EZQueryResult *)result {
 
                 } else {
                     make.top.offset(kHorizontalMargin_8);
-                    height += kVerticalPadding_8;
+                    height += kVerticalPadding_6;
                 }
             }
             CGSize labelSize = [self labelSize:meanLabel exceptedWidth:exceptedWidth];
@@ -541,15 +542,15 @@ - (void)refreshWithResult:(EZQueryResult *)result {
         [exchangeLabel mas_makeConstraints:^(MASConstraintMaker *make) {
             make.left.offset(kHorizontalMargin_8);
             if (lastView) {
-                CGFloat topPadding = kVerticalPadding_8;
+                CGFloat topPadding = kVerticalPadding_6;
                 if (idx == 0) {
                     topPadding = kVerticalMargin_12;
                 }
                 make.top.equalTo(lastView.mas_bottom).offset(topPadding);
                 height += topPadding;
             } else {
-                make.top.offset(kVerticalPadding_8);
-                height += kVerticalPadding_8;
+                make.top.offset(kVerticalPadding_6);
+                height += kVerticalPadding_6;
             }
 
             CGSize labelSize = [exchangeLabel oneLineSize];
@@ -614,11 +615,11 @@ - (void)refreshWithResult:(EZQueryResult *)result {
             [partLabel mas_makeConstraints:^(MASConstraintMaker *make) {
                 make.left.offset(kHorizontalMargin_8);
                 if (lastView) {
-                    make.top.equalTo(lastView.mas_bottom).offset(kVerticalPadding_8);
+                    make.top.equalTo(lastView.mas_bottom).offset(kVerticalPadding_6);
                 } else {
-                    make.top.offset(kVerticalPadding_8);
+                    make.top.offset(kVerticalPadding_6);
                 }
-                height += kVerticalPadding_8;
+                height += kVerticalPadding_6;
 
                 CGSize labelSize = [partLabel oneLineSize];
                 make.size.mas_equalTo(labelSize).priorityHigh();
@@ -651,13 +652,13 @@ - (void)refreshWithResult:(EZQueryResult *)result {
             exceptedWidth += leftOffset;
             make.left.offset(leftOffset); // Since button has been expanded, so need to be shifted to the left.
             if (partLabel) {
-                CGFloat topOffset = 3;
+                CGFloat topOffset = kBlueTextButtonVerticalPadding_3;
                 height += topOffset;
                 make.top.equalTo(partLabel.mas_bottom).offset(topOffset);
             } else {
                 CGFloat topOffset = kHorizontalMargin_8;
                 if (lastView) {
-                    topOffset = 5;
+                    topOffset = kBlueTextButtonVerticalPadding_3;
                     if (idx == 0) {
                         topOffset = 8;
                     }
@@ -927,8 +928,8 @@ - (NSView *)buildSynonymsAndAntonymsView:(NSString *)title parts:(NSArray<EZTran
             make.top.equalTo(rtnView.mas_bottom).offset(topPadding);
             *height += topPadding;
         } else {
-            make.top.offset(kVerticalPadding_8);
-            *height += kVerticalPadding_8;
+            make.top.offset(kVerticalPadding_6);
+            *height += kVerticalPadding_6;
         }
 
         CGSize labelSize = [synonymsTitle oneLineSize];
@@ -969,7 +970,7 @@ - (NSView *)buildSynonymsAndAntonymsView:(NSString *)title parts:(NSArray<EZTran
         }];
 
         [wrapView mas_makeConstraints:^(MASConstraintMaker *make) {
-            CGFloat topOffset = 5;
+            CGFloat topOffset = kBlueTextButtonVerticalPadding_3;
             make.top.equalTo(rtnView.mas_bottom).offset(topOffset);
             *height += topOffset;
             make.left.equalTo(partLabel.mas_right);