perf: improve Ali error message

tisfeng · Dec 21, 2023 · 6c7694e · 6c7694e
1 parent 531d826
commit 6c7694e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/Easydict/Feature/Service/Ali/AliResponse.swift b/Easydict/Feature/Service/Ali/AliResponse.swift
@@ -20,6 +20,16 @@ import Foundation
          "detectLanguage": "en"
      }
  }
+
+ error:
+ {
+     "requestId": "877D2097-6FE4-4B24-BAF1-41AB561C1E67",
+     "success": false,
+     "httpStatusCode": 500,
+     "code": "ParamError",
+     "message": "Query length limit exceeded",
+     "data": null
+ }
  */
 
 struct AliResponse: Codable {

diff --git a/Easydict/Feature/Service/Ali/AliService.swift b/Easydict/Feature/Service/Ali/AliService.swift
@@ -69,8 +69,7 @@ class AliService: QueryService {
                                              result.translatedResults = [translateText.unescapedXML()]
                                              completion(result, nil)
                                          } else {
-                                             let ezError = EZError(type: value.httpStatusCode == 500 ? .unsupportedLanguage : .noResultsFound)
-                                             ezError.errorDataMessage = value.message ?? "ali translate failed"
+                                             let ezError = EZError(type: .API, description: value.code, errorDataMessage: value.message)
                                              completion(result, ezError)
                                          }
                                      case let .failure(error):