Skip to content

Commit

Permalink
fix: type in a few files
Browse files Browse the repository at this point in the history
  • Loading branch information
Jerry23011 committed May 28, 2024
1 parent 93fd77b commit e32fa30
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions Easydict/Swift/Service/OpenAI/BaseOpenAIService.swift
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ extension BaseOpenAIService {
typealias Role = ChatCompletionMessageParam.Role

var chats: [ChatCompletionMessageParam] = []
let messages = translatioMessages(text: text, from: from, to: to)
let messages = translationMessages(text: text, from: from, to: to)
for message in messages {
if let roleRawValue = message["role"],
let role = Role(rawValue: roleRawValue),
Expand Down Expand Up @@ -183,7 +183,7 @@ extension BaseOpenAIService {
case .translation:
fallthrough
default:
messages = translatioMessages(text: text, from: from, to: to)
messages = translationMessages(text: text, from: from, to: to)
}

var chats: [ChatCompletionMessageParam] = []
Expand Down
6 changes: 3 additions & 3 deletions Easydict/Swift/Service/OpenAI/LLMStreamService.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ public class LLMStreamService: QueryService {
}

override public func supportLanguagesDictionary() -> MMOrderedDictionary<AnyObject, AnyObject> {
let allLangauges = EZLanguageManager.shared().allLanguages
let supportedLanguages = allLangauges.filter { language in
let allLanguages = EZLanguageManager.shared().allLanguages
let supportedLanguages = allLanguages.filter { language in
!unsupportedLanguages.contains(language)
}

Expand Down Expand Up @@ -105,7 +105,7 @@ public class LLMStreamService: QueryService {
return resultText
}

/// Get query type by text and from && to langauge.
/// Get query type by text and from && to language.
func queryType(text: String, from: Language, to _: Language) -> EZQueryTextType {
let enableDictionary = queryTextType().contains(.dictionary)
var isQueryDictionary = false
Expand Down
14 changes: 7 additions & 7 deletions Easydict/Swift/Service/OpenAI/Prompt.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ extension LLMStreamService {
"""

func translationPrompt(text: String, from sourceLanguage: Language, to targetLanguage: Language) -> String {
"Translate the following \(sourceLanguage.queryLangaugeName) text into \(targetLanguage.queryLangaugeName) text: \"\"\"\(text)\"\"\""
"Translate the following \(sourceLanguage.queryLanguageName) text into \(targetLanguage.queryLanguageName) text: \"\"\"\(text)\"\"\""
}

func translatioMessages(text: String, from: Language, to: Language) -> [[String: String]] {
func translationMessages(text: String, from: Language, to: Language) -> [[String: String]] {
// Use """ %@ """ to wrap user input, Ref: https://help.openai.com/en/articles/6654000-best-practices-for-prompt-engineering-with-openai-api#h_21d4f4dc3d
// let prompt = "Translate the following \(from.rawValue) text into \(to.rawValue) text: \"\"\"\(text)\"\"\""

Expand Down Expand Up @@ -138,7 +138,7 @@ extension LLMStreamService {
],
]

let fromClassicalChinseseFewShot = [
let fromClassicalChineseFewShot = [
// wyw --> zh
[
"role": "user",
Expand Down Expand Up @@ -211,7 +211,7 @@ extension LLMStreamService {
],
]

let toClassicalChinseseFewShot = [
let toClassicalChineseFewShot = [
// --> wyw
[
"role": "user",
Expand Down Expand Up @@ -256,10 +256,10 @@ extension LLMStreamService {
messages.append(contentsOf: chineseFewShot)

if from == .classicalChinese {
messages.append(contentsOf: fromClassicalChinseseFewShot)
messages.append(contentsOf: fromClassicalChineseFewShot)
}
if to == .classicalChinese {
messages.append(contentsOf: toClassicalChinseseFewShot)
messages.append(contentsOf: toClassicalChineseFewShot)
}

let userMessages = [
Expand Down Expand Up @@ -852,7 +852,7 @@ extension LLMStreamService {
}

extension Language {
var queryLangaugeName: String {
var queryLanguageName: String {
let languageName = switch self {
case .classicalChinese:
"简体中文文言文"
Expand Down

0 comments on commit e32fa30

Please sign in to comment.