fix: service list order issue and UI change

tisfeng · Jan 7, 2024 · f0e7b11 · f0e7b11
1 parent 7ae9c0a
commit f0e7b11
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Easydict/NewApp/View/ServiceItemView.swift b/Easydict/NewApp/View/ServiceItemView.swift
@@ -17,14 +17,15 @@ struct ServiceItemView: View {
         HStack {
             Image(nsImage: NSImage(named: service.serviceType().rawValue) ?? NSImage())
                 .resizable()
-                .frame(maxWidth: 24.0, maxHeight: 24.0)
+                .frame(maxWidth: 18.0, maxHeight: 18.0)
 
             Text(service.name())
 
             Toggle(isOn: $service.enabled.didSet(execute: { value in
                 toggleValueChanged(value)
             })) {}
                 .toggleStyle(.switch)
+                .controlSize(.small)
         }
 
         .padding(4.0)

diff --git a/Easydict/NewApp/View/SettingView/Tabs/ServiceTab.swift b/Easydict/NewApp/View/SettingView/Tabs/ServiceTab.swift
@@ -82,6 +82,8 @@ struct ServiceTab: View {
         }
         let windowType = EZWindowType(rawValue: windowTypeValue) ?? .none
         EZLocalStorage.shared().setService(services[index], windowType: windowType)
+        // refresh service list
+        loadService(type: windowTypeValue)
         postUpdateServiceNotification()
     }
 
@@ -90,15 +92,17 @@ struct ServiceTab: View {
     }
 
     func onServiceItemMove(fromOffsets: IndexSet, toOffset: Int) {
+        let oldEnabledServices = enabledServices(in: services)
+
         services.move(fromOffsets: fromOffsets, toOffset: toOffset)
         serviceTypes.move(fromOffsets: fromOffsets, toOffset: toOffset)
 
-        let oldEnabledServices = enabledServices(in: services)
         let windowType = EZWindowType(rawValue: windowTypeValue) ?? .none
         EZLocalStorage.shared().setAllServiceTypes(serviceTypes, windowType: windowType)
         let newServices = EZLocalStorage.shared().allServices(windowType)
         let newEnabledServices = enabledServices(in: newServices)
 
+        // post notification after enabled services order changed
         if isEnabledServicesOrderChanged(source: oldEnabledServices, dest: newEnabledServices) {
             postUpdateServiceNotification()
         }
@@ -114,8 +118,7 @@ struct ServiceTab: View {
     }
 
     func postUpdateServiceNotification() {
-        let windowType = EZWindowType(rawValue: windowTypeValue) ?? .none
-        let userInfo: [String: Any] = [EZWindowTypeKey: windowType]
+        let userInfo: [String: Any] = [EZWindowTypeKey: windowTypeValue]
         let notification = Notification(name: .serviceHasUpdated, object: nil, userInfo: userInfo)
         NotificationCenter.default.post(notification)
     }