chore: extract func for check is tips cell

tisfeng · Feb 24, 2024 · f206d7f · f206d7f
1 parent 7b4128d
commit f206d7f
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/Easydict/Feature/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m b/Easydict/Feature/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
@@ -373,6 +373,10 @@ - (BOOL)isShowTipsView {
     return NO;
 }
 
+- (BOOL)isTipsCellRow:(NSInteger)row {
+    return (self.isShowTipsView && row == 2 && self.windowType != EZWindowTypeMini) || (self.isShowTipsView && row == 1);
+}
+
 #pragma mark - Public Methods
 
 /// Before starting query text, close all result view.
@@ -807,7 +811,7 @@ - (nullable NSView *)tableView:(NSTableView *)tableView viewForTableColumn:(null
     }
 
     // show tips view
-    if ((self.isShowTipsView && row == 2 && self.windowType != EZWindowTypeMini) || (self.isShowTipsView && row == 1)) {
+    if ([self isTipsCellRow:row]) {
         EZTableTipsCell *tipsCell = [self.tableView makeViewWithIdentifier:EZTableTipsCellId owner:self];
         if (!tipsCell) {
             tipsCell = [[EZTableTipsCell alloc] initWithFrame:[self tableViewContentBounds]];
@@ -832,8 +836,7 @@ - (CGFloat)tableView:(NSTableView *)tableView heightOfRow:(NSInteger)row {
         height = self.queryModel.queryViewHeight;
     } else if (row == 1 && self.windowType != EZWindowTypeMini) {
         height = 35;
-    } else if ((row == 2 && self.isShowTipsView && self.windowType != EZWindowTypeMini) || 
-               (row == 1 && self.isShowTipsView)) {
+    } else if ([self isTipsCellRow:row]) {
         if (!self.tipsCell) {
             height = 100;
         } else {