perf: unify xcstring in about view

tisfeng · May 6, 2024 · f7721a3 · f7721a3
1 parent f6988b3
commit f7721a3
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 34 deletions.
diff --git a/Easydict/App/Localizable.xcstrings b/Easydict/App/Localizable.xcstrings
@@ -829,22 +829,6 @@
         }
       }
     },
-    "contributor_link" : {
-      "localizations" : {
-        "en" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "Contributors"
-          }
-        },
-        "zh-Hans" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "贡献者"
-          }
-        }
-      }
-    },
     "copy_text" : {
       "localizations" : {
         "en" : {
@@ -1468,22 +1452,6 @@
         }
       }
     },
-    "github_link" : {
-      "localizations" : {
-        "en" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "GitHub"
-          }
-        },
-        "zh-Hans" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "GitHub"
-          }
-        }
-      }
-    },
     "GitHub:" : {
       "localizations" : {
         "zh-Hans" : {
@@ -3299,6 +3267,38 @@
         }
       }
     },
+    "setting.about.contributor_link" : {
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Contributors"
+          }
+        },
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "贡献者"
+          }
+        }
+      }
+    },
+    "setting.about.github_link" : {
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "GitHub"
+          }
+        },
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "GitHub"
+          }
+        }
+      }
+    },
     "setting.disabled.import_app_error.message" : {
       "extractionState" : "manual",
       "localizations" : {

diff --git a/Easydict/Swift/View/SettingView/Tabs/TabView/AboutTab.swift b/Easydict/Swift/View/SettingView/Tabs/TabView/AboutTab.swift
@@ -84,15 +84,15 @@ struct AboutTab: View {
                                 Button {
                                     NSWorkspace.shared.open(URL(string: "https://github.com/tisfeng/Easydict")!)
                                 } label: {
-                                    Label("github_link", systemImage: "star.fill")
+                                    Label("setting.about.github_link", systemImage: "star.fill")
                                         .frame(width: 120, height: 20)
                                 }
 
                                 Button {
                                     NSWorkspace.shared
                                         .open(URL(string: "https://github.com/tisfeng/Easydict/graphs/contributors")!)
                                 } label: {
-                                    Label("contributor_link", systemImage: "person.3.sequence.fill")
+                                    Label("setting.about.contributor_link", systemImage: "person.3.sequence.fill")
                                         .frame(width: 120, height: 20)
                                 }
                             }