Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Swift 重构】使用新的 Swift 快捷键第三方库替换 MASShortcut #290

Closed
Tracked by #285 ...
tisfeng opened this issue Dec 30, 2023 · 12 comments
Closed
Tracked by #285 ...
Assignees
Labels

Comments

@tisfeng
Copy link
Owner

tisfeng commented Dec 30, 2023

目前项目中快捷键第三方库使用的是 objc 写的 MASShortcut ,这个库已经停止维护了, 并且不支持 double tap #220

虽然有小伙伴通过修改源码的方式支持了 double tap #277 ,但这终结不是长远之计,因此后面还是希望使用新的 Swift 快捷键第三方库替换 MASShortcut

@tisfeng
Copy link
Owner Author

tisfeng commented Dec 30, 2023

@AkaShark 你可以负责替换这个吗?

@AkaShark
Copy link
Collaborator

okay 话说有推荐的较为成熟的Swift的快捷键的库不,没有的话我明天的呀

@tisfeng
Copy link
Owner Author

tisfeng commented Dec 30, 2023

我对 Swift 第三方库不太了解, KeyHolder 这个看起来好像还不错,或许可以尝试一下。

image

@AkaShark
Copy link
Collaborator

我是刚接触Swift😂,可以明天我研究下的~

@tisfeng tisfeng changed the title 【Swift 重构】使用新的 Swift 快捷键第三方库替换 MASPreferences 【Swift 重构】使用新的 Swift 快捷键第三方库替换 MASShortcut Dec 31, 2023
@tisfeng
Copy link
Owner Author

tisfeng commented Dec 31, 2023

KeyHolder 如果没问题,你可以在新的设置页 GeneralTab 里面用 SwiftUI 方式添加这些快捷键。

image

@AkaShark
Copy link
Collaborator

okay

@liyafly
Copy link
Contributor

liyafly commented Jan 6, 2024

hi 老兄,我刚查到 KeyboardShortcuts 这个库 看着还不错 你可以试一下。如果有困难,我愿意和您一起补齐这个功能。

@AkaShark
Copy link
Collaborator

AkaShark commented Jan 6, 2024

hi 老兄,我刚查到 KeyboardShortcuts 这个库 看着还不错 你可以试一下。如果有困难,我愿意和您一起补齐这个功能。

Thanks for your suggestion, but I‘m using KeyHolder to replace the shortcut.

@tisfeng
Copy link
Owner Author

tisfeng commented Jan 14, 2024

设置和菜单界面部分已经完成,你后面只要把快捷键添加上去就可以。

@AkaShark
Copy link
Collaborator

okay, I've been busy lately, I will finish this in the next week

@tisfeng
Copy link
Owner Author

tisfeng commented Jan 14, 2024

👌

@donfishman
Copy link

Swift快捷键的库有KeyboardShortcuts,还有一个HotKey,也不错

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants