Add shortcut with keyholder

[AkaShark]

closed #290

[tisfeng]

App crashed when I use the shortcut key Opt+S in old settings, I only set a new shortcut key Opt+A in new settings, Opt+A works fine.

Magnet/HotKeyCenter.swift:140: Assertion failed: Invalid hot key id

[AkaShark]

App crashed when I use the shortcut key Opt+S in old settings, I only set a new shortcut key Opt+A in new settings, Opt+A works fine.

Magnet/HotKeyCenter.swift:140: Assertion failed: Invalid hot key id

okay, I repeated this crash, seems caused by the conflict between keyholder and MAShortcut, I also purposely used different Key values.... Let me see more details, I will fix this later.

[tisfeng]

The shortcut keys group looks inconsistent with the overall page layout.

Maybe we can move the shortcut keys to a separate page and optimize the layout. For example, there is no need for dividing lines, and the shortcut key view needs to be left aligned.

[AkaShark]

The shortcut keys group looks inconsistent with the overall page layout.

Maybe we can move the shortcut keys to a separate page and optimize the layout. For example, there is no need for dividing lines, and the shortcut key view needs to be left aligned.

That sounds like a good idea! I will move shortcut to another page, and optimize the layout

[tisfeng]

MAShortcut

App crashed when I use the shortcut key Opt+S in old settings, I only set a new shortcut key Opt+A in new settings, Opt+A works fine.

Magnet/HotKeyCenter.swift:140: Assertion failed: Invalid hot key id

I just fixed it in a simple way, and I didn't confirm the conflict between keyholder and MAShortcut.

    if (!EasydictNewAppManager.shared.enable) {
        [EZMenuItemManager.shared setup];
        [EZShortcut setup];
    } else {
        [Shortcut setupShortcut];
    }

[AkaShark]

MAShortcut

App crashed when I use the shortcut key Opt+S in old settings, I only set a new shortcut key Opt+A in new settings, Opt+A works fine.

Magnet/HotKeyCenter.swift:140: Assertion failed: Invalid hot key id

I just fixed it in a simple way, and I didn't confirm the conflict between keyholder and MAShortcut.

    if (!EasydictNewAppManager.shared.enable) {
        [EZMenuItemManager.shared setup];
        [EZShortcut setup];
    } else {
        [Shortcut setupShortcut];
    }

You are right, that is a smart way !

[tisfeng]

This shortcut key layout looks weird.

[AkaShark]

This shortcut key layout looks weird.

yeah, that is my problem, in UIKit we can use NSMenuItem to add keyEquicalent and keyEquivalentModifierMask

But in SwiftUI I can't find the property

If I use .keyboardShortcut user can't add a double modifier key. I tried to use HStack but it did seem not good 😭

[tisfeng]

I tried this code, looks good.

[AkaShark]

This feature is ready. Please review the change.

[phlpsong]

There are some localized strings marked as need_review, do we need to update this?

[AkaShark]

There are some localized strings marked as need_review, do we need to update this?

yeah, I think we need to mark the changes that we confirm as reviewed. I have marked this as reviewed.

[tisfeng]

Looks good.

done

[tisfeng]

I will merge this PR soon if there are no other questions.