Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug Report: Shortcuts bugs in SwiftUI #399

Closed
4 of 5 tasks
tisfeng opened this issue Feb 10, 2024 · 6 comments
Closed
4 of 5 tasks

🐞 Bug Report: Shortcuts bugs in SwiftUI #399

tisfeng opened this issue Feb 10, 2024 · 6 comments
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available

Comments

@tisfeng
Copy link
Owner

tisfeng commented Feb 10, 2024

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version
  • I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Problem description

I cleared the shortcut in the settings, but I still see it in the menu items, it seems to have been reset to the default shortcut.

For in-app shortcuts, it's weird that it still works after clearing it.

Also, if I clear the shortcut and restart the app, it gets reset to the default shortcut again, like this #395 (comment)

Is the issue consistently reproducible?

Reproducible

Steps to Reproduce

This issue can be reproduced in both debug and release environments.

Screenshot

iShot_2024-02-10_13.59.19.mp4

Expected result

Proposed solution (optional)

No response

Device type and OS version

Are you willing to submit a PR to fix this issue?

  • I'm willing to submit a PR
@AkaShark
Copy link
Collaborator

In this PR #398, this issue will be closed

@tisfeng
Copy link
Owner Author

tisfeng commented Feb 10, 2024

ok

@phlpsong
Copy link
Collaborator

Maybe it should be assigned to @CanglongCl or @AkaShark ?

@CanglongCl
Copy link
Collaborator

Already fixed with #398. Sorry I forgot to close this issue.

@tisfeng
Copy link
Owner Author

tisfeng commented Feb 17, 2024

Please note that for issues that affect the production environment, even if we have fixed them in dev, we should use fixed in next release tag instead of closing them directly.

I will close these types of issues later when we release a new version.

Since we usually will not release patched versions once code is merged, closing the issue will lead some users to mistakenly think the issue has been fixed(but the current app has not), so they may open a bug issue again 😑

@tisfeng tisfeng reopened this Feb 17, 2024
@tisfeng
Copy link
Owner Author

tisfeng commented Feb 25, 2024

2.6.1 版本已修复该问题。

@tisfeng tisfeng closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

4 participants