Implement global shortcuts default value in SwiftUI Mode #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CanglongCl
requested review from
tisfeng,
AkaShark,
phlpsong,
NeverAgain11,
choykarl,
Kyle-Ye and
Jerry23011
|
No, we can't set the default for global shortcut default using |
CleanShot.2024-02-09.at.20.42.38.mp4 |
You are right. It is a old issue in I'll revert it. |
BTW in release 2.6.0 it works well. I'm not sure why. |
5 tasks
|
I opened a new issue to track shortcuts bugs #399 |
tisfeng
added a commit
that referenced
this pull request
Feb 13, 2024
* fix: default value in short cut * refactor: delete unused file * Revert "refactor: delete unused file" This reverts commit 3a2d734. * Revert "fix: default value in short cut" This reverts commit fdfe495. * Add default shortcut * split `setDefaultForAppShortcut` into 2 method * fix: default value in short cut * refactor: delete unused file * Revert "refactor: delete unused file" This reverts commit 3a2d734. * Revert "fix: default value in short cut" This reverts commit fdfe495. * Add default shortcut * split `setDefaultForAppShortcut` into 2 method * Revert "chore: update issue templates" This reverts commit 033e391. * fix: correct default global shortcut keys --------- Co-authored-by: tisfeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.