-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CaiyunService Support #218
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
抽空弄了下初步支持上了,这周还有其他事情不一定有时间能完全弄完 cc @tisfeng TODO:
|
b4aafac
to
f91eb84
Compare
试了一下,看起来不错。 没事,我这边可以自己先做,你稍后抽空完善一下就好。 |
077bd1c
to
1b4ca89
Compare
我看到 GitGuardian Security Checks 这个警告还在,以为是 token 切割不彻底,但看起来不是,而是因为泄漏 token 的提交记录已经推送了。。 看了一下文档 https://blog.gitguardian.com/rewriting-git-history-cheatsheet/ ,要想消除警告有点麻烦,这只是一个测试 token,问题不大,还是算了吧 😔 |
ed454b0
to
b9d07ea
Compare
Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <[email protected]>
b9d07ea
to
4762aec
Compare
@Kyle-Ye 完善了一下代码,你看看还有没有什么要改的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the help
* Fix header issue * Add basic support for CaiyunService Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <[email protected]> * perf: improve multiple texts translation * chore: add swiftpm/Package.resolved * perf: add more supported languages * perf: rename EZCaiyunAPIKey to EZCaiyunToken * perf: set auto convert Chinese text to true * perf: support traditional Chinese as target language * refactor: auto convert to traditional Chinese texts if need * perf: localize LingoCloud as English name * perf: update Localizable.xcstrings * perf: localize unsupported_translation_type * perf: improve transType() * fix: only auto convert to traditional Chinese when matching query target language * perf: improve supportLanguagesDictionary() --------- Co-authored-by: tisfeng <[email protected]>
* Fix header issue * Add basic support for CaiyunService Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <[email protected]> * perf: improve multiple texts translation * chore: add swiftpm/Package.resolved * perf: add more supported languages * perf: rename EZCaiyunAPIKey to EZCaiyunToken * perf: set auto convert Chinese text to true * perf: support traditional Chinese as target language * refactor: auto convert to traditional Chinese texts if need * perf: localize LingoCloud as English name * perf: update Localizable.xcstrings * perf: localize unsupported_translation_type * perf: improve transType() * fix: only auto convert to traditional Chinese when matching query target language * perf: improve supportLanguagesDictionary() --------- Co-authored-by: tisfeng <[email protected]>
Close #206