-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TencentService Support #240
Conversation
Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <[email protected]>
Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <[email protected]>
太棒了,请问这个通知是在哪里看到的,你有收到邮件通知吗? |
不知道 Easydict 是不是属于"popular open source project"了
|
等我先发个新版本,晚上再看。 |
我没注意到,我之前是付费使用 GitHub Copilot,不知道什么时候激活了免费资格,它又不给发邮件通知。。 @choykarl 你记得是什么时候拿到免费资格的吗,我比较好奇这个所谓 “流行开源项目” 标准是什么? |
这里最好不要使用自动 git pull 方式 merge,会显示多余的提交,建议使用 rebase 方法,保持提交历史简洁。 我电脑默认设置 git pull 就是 rebase: git config --global pull.rebase true 参考 https://git-scm.com/book/zh/v2/Git-%E5%88%86%E6%94%AF-%E5%8F%98%E5%9F%BA
|
@Jerry23011 @choykarl 建议都设置这种方式,每次提交前都 rebase 一下最新分支代码。 |
原来如此,我是纯GUI,回头学习一下CLI |
彻底懵了,@tisfeng 我回头再开一个 branch + PR,这个先放在这,我试验试验 |
a4dbf82
to
08d6880
Compare
另外,这种和 PR 无关的操作,不要放一起提交,应该单独 PR |
收到🫡 |
b7b5e5e
to
cde888f
Compare
撤回了,再也不敢不测试就瞎 push 了 :) |
本地怎么测试操作都行,只是推送前一定要注意提交的内容,也要确保代码能编译运行。 |
试了一下,虽然文档上没写,但发现腾讯翻译是支持繁体中文的,只要目标语言支持简体中文的都支持繁体中文。 |
df302d7
to
89829ad
Compare
文档反馈了,也不知道有没有用
试了一下这个,确实是会保留 commit 时间的 |
db6447c
to
2e49e6f
Compare
这个看起来没什么问题,我就先合并了,游离主分支太久不好,也不方便测试。 后面如果没问题,这周末会发一个新版本。 |
至于后面的图片翻译和 OCR,你可以另外提 PR。 |
OK,最近一直没来得及看这个 |
* Add basic support for CaiyunService Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <[email protected]> * Add basic support for CaiyunService Add basic implementation for Caiyun Service Fix CR suggestion Add caiyun service transtype support perf: split caiyun test token to more parts perf: improve caiyun supported langauges dict Update Easydict/Feature/Service/Caiyun/CaiyunService.swift Co-authored-by: Kyle <[email protected]> * feat: initiate Tencent Translate support * feat: continue building Tencent Translate * fix: error when detecting unsupported languages in transType * style: code formatting * feat: proceed to Authentication header * fix: re-add TencentAPIKek * Fix header issue * fix: remove duplicated EZTencentAPIKey * perf: optimize logic in TencentTranslateType.swift * perf: optimize and localize error handling in unsupported languages * perf(UI): add English localization for Tencent Translate * perf: optimize MMOrderedDictionary logic * perf(UI): revert TMT icon * perf: initialize support for secrets customization * perf: implement demo for authentication * fix: proper json decoding * feat: implement secrets customization * style: format code Format with SwiftLint * perf: add self support language * fix: build error * perf(UI): adopt official name of Tencent Translate Co-Authored-By: Tisfeng <[email protected]> * perf: create headerAuth func for authorization * perf(UI): delete Tencent TTS in dropdown * refactor: improve tencent sign * refractor: improve tencent sign Co-Authored-By: Tisfeng <[email protected]> * fix: tencent api endpoint * Revert "perf: add self support language" This reverts commit 0bc2ab1. * perf: update handling of language * fix: correct supportedTypes * style: format code fixed extraneous white spaces with SwiftLint * perf: prepares TencentSigning for other services * perf: enable tencent from == to * perf: add missing traditional Chinese target language * perf: improve tencent error message * perf: map error response --> Response --------- Co-authored-by: Kyle <[email protected]> Co-authored-by: tisfeng <[email protected]>
Closes #182