feat: Add support for customising the appearance of the app #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你好，请问这个 PR 完成了吗？如果已完成，就可以找人 request review 代码了。 
|
|
我跑了一下，效果看起来不对劲 🥲 
|
tisfeng
reviewed
Dec 29, 2023
tisfeng
requested changes
Dec 29, 2023
|
问题已修复 |
Co-authored-by: Tisfeng <[email protected]>
tisfeng
approved these changes
Dec 29, 2023
|
奇怪，合并这个 PR 后，最新的 dev 编译会报错 
|
|
看了一下，好像是引用循环，EZConfiguration.h 文件引用了 #import "Easydict-Swift.h"，而桥接文件 Easydict-Bridging-Header.h 又添加了 #import "EZConfiguration.h" 😥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #253