Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio and text copy button enable/disable state #296

Closed
wants to merge 1 commit into from

Conversation

phlpsong
Copy link
Collaborator

@phlpsong phlpsong commented Jan 2, 2024

Update the audio button and text copy button disable state while query text is empty.

Please help to review this PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello phlpsong, Thank you for your first PR contribution 🎉 phlpsong

@tisfeng
Copy link
Owner

tisfeng commented Jan 2, 2024

感谢 PR,我试了一下,设置为 disable 状态后,感觉视觉效果不是很好,也可能是之前 enable 视觉看习惯了,因此这里我暂时还不想改。

如果你对这个项目感兴趣,可以帮忙看看其他的 issue。

image

@phlpsong
Copy link
Collaborator Author

phlpsong commented Jan 2, 2024

@tisfeng thanks for your review comment.
What confused me here is I could do audio play or copy action while empty input(even though this has no effect).
I checked both light and dark appearance, it looks fine from my side.

@phlpsong
Copy link
Collaborator Author

phlpsong commented Jan 2, 2024

@tisfeng Sure, if you don't want this change, I will close this PR later and check other issues if I can help.

@tisfeng
Copy link
Owner

tisfeng commented Jan 2, 2024

这个暂时保持原样,你可以帮帮看其他 issue。

@tisfeng tisfeng closed this Jan 2, 2024
@phlpsong phlpsong deleted the phlpsong/query-btn-state branch January 9, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants