Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite openai with Swift #308

Closed
wants to merge 30 commits into from
Closed

refactor: rewrite openai with Swift #308

wants to merge 30 commits into from

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Jan 6, 2024

No description provided.

Copy link

gitguardian bot commented Jan 6, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
9208178 Generic High Entropy Secret 7998646 Easydict/Feature/Service/OpenAI/OpenAIService.swift View secret
9208178 Generic High Entropy Secret cabd944 Easydict/Feature/Service/OpenAI/OpenAIService.swift View secret
9208178 Generic High Entropy Secret 2fb666c Easydict/Feature/Service/OpenAI/OpenAIService.swift View secret
9208178 Generic High Entropy Secret 2fb666c Easydict/Feature/Service/OpenAI/OpenAIService.swift View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

choykarl and others added 24 commits January 6, 2024 12:03
* add ali translate support

* use camel case to name AliAPIResponse

* use prefix func to get a substring
* fix: issue #298 menu item alignment issue

* fix: update format

* Update Easydict/Feature/StatusItem/EZMenuItemManager.m

Co-authored-by: Tisfeng <[email protected]>

---------

Co-authored-by: Tisfeng <[email protected]>
…306)

* perf: use NSLocale.preferredLanguages instead of NSUserDefaults AppleLanguages

* bugfix: #305 reset AppleLanguages values

---------

Co-authored-by: tisfeng <[email protected]>
set GENERATE_DEBUGGING to NO

(x86_64)  could not find object file symbol for symbol _protobuf_c_version
This reverts commit c864f76.
@tisfeng
Copy link
Owner Author

tisfeng commented Jan 6, 2024

测试一下 CodeQL,后面会重新整理 commit。

@tisfeng
Copy link
Owner Author

tisfeng commented Jan 6, 2024

ci 看起来没问题。

@tisfeng tisfeng closed this Jan 6, 2024
@tisfeng tisfeng deleted the refactor-openai branch January 18, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants