Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add some missing English translations #327

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

phlpsong
Copy link
Collaborator

missing English translations in the Menu and General tab.

@phlpsong phlpsong requested a review from tisfeng January 15, 2024 05:41
@phlpsong phlpsong force-pushed the phlpsong/missing_translations branch from 313fdee to 4adb322 Compare January 15, 2024 05:48
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
@tisfeng
Copy link
Owner

tisfeng commented Jan 15, 2024

Please check all Localizable.xcstrings, including Chinese and English, mark them all as reviewed, some of them may not be used, just ignore them.

image

@tisfeng tisfeng requested a review from Jerry23011 January 15, 2024 16:33
@phlpsong
Copy link
Collaborator Author

@tisfeng @Jerry23011 If there are no other issues, please kindly merge this.

@tisfeng
Copy link
Owner

tisfeng commented Jan 16, 2024

ok

@tisfeng tisfeng merged commit 2ae4e7e into tisfeng:dev Jan 16, 2024
5 checks passed
@phlpsong phlpsong deleted the phlpsong/missing_translations branch January 16, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants