Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W][macos-10.15] - change Alamofire version. / add some icon | log. #329

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

whoooami
Copy link

@whoooami whoooami commented Jan 16, 2024

close #251

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello whoooami, Thank you for your first PR contribution 🎉 whoooami

@tisfeng
Copy link
Owner

tisfeng commented Jan 16, 2024

由于 SF 图片大部分在 macOS-10.15 不可用,所以我干脆移除了。

现在有些代码会报错,你需要把 ez_imageWithSymbolName 方法

    NSImage *linkImage = [NSImage ez_imageWithSymbolName:@"link"];

改成 imageNamed,然后校验对应的图片资源,比如 link,如果不存在,需要补充。

    NSImage *linkImage = [NSImage imageNamed:@"link"];
image

@tisfeng
Copy link
Owner

tisfeng commented Jan 17, 2024

你好,现在的代码还有问题吗?

@whoooami
Copy link
Author

你好,现在的代码还有问题吗?

简单看了下ui没发现问题。但是tableview的循环渲染还是存在的

@tisfeng
Copy link
Owner

tisfeng commented Jan 18, 2024

@whoooami 我这边 macOS 14.2.1 测试没有问题,不清楚你那边的运行环境是什么情况,你可以打断点调试一下,看到底哪个地方死循环了。

如果实在没有办法解决,只能先放着,看后续有没有别的使用 macOS 10.15 系统的用户来修复。

@tisfeng
Copy link
Owner

tisfeng commented Jan 18, 2024

支持旧版本太累了,除非是用户机器硬件限制无法更新,否则只要条件支持,都建议升级到最新系统。

macOS 10.15 这个分支可以保留,但后续我不会继续维护,只接受 PR。如果代码运行没有问题,会看情况发布 release 版本。

目前项目最低支持 macOS 11,后面的新版本使用了很多 SwiftUI 特性,可能会只支持 macOS 13+。

@tisfeng tisfeng merged commit 45f2367 into tisfeng:macos-10.15 Jan 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants