Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable app list lag issue #347

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

phlpsong
Copy link
Collaborator

@phlpsong phlpsong commented Jan 20, 2024

List item views may refresh after selection changes. This change will prevent content refresh after each selection.

After select too many apps in the list, you may experience significant lag behaviors.

@phlpsong
Copy link
Collaborator Author

@CanglongCl This will revert some changes in #340, please kindly check it. Any questions or suggestions, please let me know.

@tisfeng
Copy link
Owner

tisfeng commented Jan 20, 2024

I tested this code, it doesn't fix on my mac.

@tisfeng
Copy link
Owner

tisfeng commented Jan 20, 2024

I actually tried the previous workaround #346 (comment) in SwiftUI and it worked, although it's not elegant.

If possible, you can try to find out the specific reason.

@phlpsong
Copy link
Collaborator Author

I tested this code, it doesn't fix on my mac.

To clarify, this is not a fix for #346.

You could reproduce this issue by:

  1. Click + to open app importer
  2. Select some apps, maybe 10 above
  3. Switch the tab or select the apps

you may experience the list lag sometimes

@tisfeng
Copy link
Owner

tisfeng commented Jan 20, 2024

Sorry, I misunderstood.

@phlpsong
Copy link
Collaborator Author

I actually tried the previous workaround #346 (comment) in SwiftUI and it worked, although it's not elegant.

If possible, you can try to find out the specific reason.

Sure, I will try.

@tisfeng tisfeng merged commit 5384b39 into tisfeng:dev Jan 21, 2024
5 checks passed
@phlpsong phlpsong deleted the disabled_list_lag branch January 22, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants