-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable scrolling in Privacy Tab #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the Privacy Tab, I don't have a strong feeling on whether to make it scrollable or not.
I had a look at the macOS system settings, basically all of them are scrollable, even for the ones that have very few elements, such as the Software Update pane, which I guess is also implemented with SwiftUI's Form
.
So I prefer to keep it unchanged, let it be scrollable by default.

I would say that we are comparing with other macOS apps instead of the system setting. The settings views are not scrollable in Apple’s default apps, so I’m thinking we want to follow that convention Edit: The ultimate goal would be to make all tabs unscrollable. Since the built-in apps are doing so |
I don't think we can make all setting view fixed since our setting is so heavy and will get heavier in the future. For privacy tab, it is not a big problem since it is hardly perceived it. |
That's a very good point. Perhaps we can leave this PR on hold for a while as we observe how the migration goes. What do you think @tisfeng |
Wait, I just thought of a use case. Since users are scrolling through General/Advanced; it's natural that they think Privacy is scrollable. Making Privacy unscrollable would create inconsistencies. Closing this, will track it in #344 |
Yes, That is also an aspect I have considered. |
We will try to make each tab “unscrollable" so that it's consistent with other macOS app settings.