Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify menu bar icon #370

Merged
merged 19 commits into from
Feb 1, 2024
Merged

Modify menu bar icon #370

merged 19 commits into from
Feb 1, 2024

Conversation

choykarl
Copy link
Collaborator

@choykarl choykarl requested a review from tisfeng January 28, 2024 16:02
@tisfeng
Copy link
Owner

tisfeng commented Jan 29, 2024

Note that each PR needs at least 2 collaborator approvals to merge, so please seek review from more than one person.

tisfeng
tisfeng requested changes Jan 29, 2024
View reviewed changes
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift Outdated Show resolved Hide resolved
Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift Outdated Show resolved Hide resolved
@Jerry23011
Copy link
Collaborator

Jerry23011 commented Jan 29, 2024 •
edited
Loading

My apologies, accidentally commited when I tried to comment

Jerry23011
Jerry23011 previously approved these changes Jan 29, 2024
View reviewed changes
tisfeng
tisfeng requested changes Jan 29, 2024
View reviewed changes
Easydict/NewApp/EasydictApp.swift Outdated Show resolved Hide resolved
Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift Outdated Show resolved Hide resolved
@Jerry23011 Jerry23011 self-requested a review January 29, 2024 02:37
Jerry23011
Jerry23011 reviewed Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could display the white base colour icon under dark mode
截屏2024-01-28 18 37 39

tisfeng
tisfeng requested changes Jan 29, 2024
View reviewed changes
Easydict/NewApp/EasydictApp.swift Outdated Show resolved Hide resolved
Easydict/NewApp/EasydictApp.swift Outdated Show resolved Hide resolved
@choykarl
Copy link
Collaborator Author

I'm wondering if we could display the white base colour icon under dark mode 截屏2024-01-28 18 37 39

如果这里显示浅色图标，那么对应的菜单栏上是不是也应该显示浅色图标。否则感觉像是选择的不生效。

@choykarl choykarl requested a review from tisfeng January 29, 2024 16:04
AkaShark
AkaShark previously approved these changes Jan 30, 2024
View reviewed changes
tisfeng
tisfeng requested changes Jan 30, 2024
View reviewed changes
Easydict/NewApp/EasydictApp.swift Show resolved Hide resolved
Easydict/NewApp/EasydictApp.swift Show resolved Hide resolved
@tisfeng tisfeng requested a review from CanglongCl January 31, 2024 14:32
@tisfeng
Copy link
Owner

tisfeng commented Feb 1, 2024

Please review this PR, push it forward.

@tisfeng tisfeng merged commit 8a3715d into tisfeng:dev Feb 1, 2024
5 checks passed
@choykarl choykarl deleted the modify_menu_bar_icon branch March 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlpsong phlpsong phlpsong approved these changes

@Jerry23011 Jerry23011 Jerry23011 approved these changes

@CanglongCl CanglongCl CanglongCl approved these changes

@tisfeng tisfeng tisfeng approved these changes

@AkaShark AkaShark AkaShark left review comments

@NeverAgain11 NeverAgain11 Awaiting requested review from NeverAgain11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@choykarl @tisfeng @Jerry23011 @AkaShark @CanglongCl @phlpsong