translation service api key config

[phlpsong]

#342

[tisfeng]

I tried it, it looks great.

I just adjust the settings page window size, make it looks better.

[phlpsong]

I didn't modify this Picker value by code before, but after I chose a value, everything seems ok, as well as no strange log.

Yes, the value in UserDefaults is an empty string, which will cause this warning.

[CanglongCl]

I didn't modify this Picker value by code before, but after I chose a value, everything seems ok, as well as no strange log.

Yes, the value in UserDefaults is an empty string, which will cause this warning.

We should replace key type of deepLTranslation to DeepLAPIUsagePriority instead of String

[CanglongCl]

@CanglongCl Could you kindly share the root cause of this warning? Did update Publish from background cause this warning?

I'm not quite familiar with concurrency as well. But usually I fix those warning with replace all codes that influence UI with DispatchQueue.main.async and it always works. But this time it seems it is caused by old .alert() which is deprecated.

[phlpsong]

I didn't modify this Picker value by code before, but after I chose a value, everything seems ok, as well as no strange log.

Yes, the value in UserDefaults is an empty string, which will cause this warning.

We should replace key type of deepLTranslation to DeepLAPIUsagePriority instead of String

I have trid to replace it with DeepLAPIUsagePriority and conforms Defaults.Serializable protocol, but the warning still exists.

[CanglongCl]

I didn't modify this Picker value by code before, but after I chose a value, everything seems ok, as well as no strange log.

Yes, the value in UserDefaults is an empty string, which will cause this warning.

We should replace key type of deepLTranslation to DeepLAPIUsagePriority instead of String

I have trid to replace it with DeepLAPIUsagePriority and conforms Defaults.Serializable protocol, but the warning still exists.

We should not use rawValue here. Just use type it self.

[tisfeng]

Looks good.

[tisfeng]

Please continue to review.

[tisfeng]

Good job!

[phlpsong]

Thank you guys. 🙌

[tisfeng]

This code looks a bit redundant, I don't see where it's being used.