In app shortcut #389
Merged
In app shortcut #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkaShark
requested review from
choykarl,
CanglongCl,
Jerry23011,
NeverAgain11,
tisfeng and
phlpsong
Jerry23011
previously approved these changes
Feb 5, 2024
CanglongCl
previously approved these changes
Feb 5, 2024
tisfeng
reviewed
Feb 5, 2024
tisfeng
reviewed
Feb 5, 2024
tisfeng
requested changes
Feb 5, 2024
Easydict/NewApp/View/SettingView/Tabs/View/Shortcut/AppShortcutSetting.swift
Outdated
Show resolved
Hide resolved
Easydict/NewApp/View/SettingView/Tabs/View/Shortcut/GlobalShortcutSetting.swift
Outdated
Show resolved
Hide resolved
|
Sometimes, when I clear this shortcut and set it again to the same as before, it may give a false alert. 
|
phlpsong
requested changes
Feb 5, 2024
Easydict/NewApp/View/SettingView/Tabs/View/Shortcut/AppShortcutSetting.swift
Outdated
Show resolved
Hide resolved
Easydict/NewApp/View/SettingView/Tabs/View/Shortcut/AppShortcutSetting.swift
Outdated
Show resolved
Hide resolved
I meeting this problem too, I close the settings page and open it again everything is ok. I think to resolve this will find a moment to update the |
tisfeng
reviewed
Feb 6, 2024
Easydict/NewApp/View/SettingView/Tabs/View/Shortcut/AppShortcutSetting.swift
Outdated
Show resolved
Hide resolved
tisfeng
reviewed
Feb 6, 2024
Easydict/NewApp/View/SettingView/Tabs/View/Shortcut/AppShortcutSetting.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Tisfeng <[email protected]>
phlpsong
requested changes
Feb 6, 2024
I opened a new issue to track this bug #391 |
tisfeng
previously approved these changes
Feb 6, 2024
phlpsong
requested changes
Feb 7, 2024
phlpsong
approved these changes
Feb 7, 2024
|
I'll merge this PR soon if no other questions. |
|
Good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #352