Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: service toggle selection issue #390

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: service toggle selection issue #390

merged 1 commit into from
Feb 6, 2024

Conversation

phlpsong
Copy link
Collaborator

@phlpsong phlpsong commented Feb 6, 2024

Jerry23011
Jerry23011 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Also fixes the issue:

In Settings, Services tab, the list seems to wear off along with the elements when scrolling to the top/bottom

@tisfeng tisfeng merged commit cfe29c7 into tisfeng:dev Feb 6, 2024
5 checks passed
@phlpsong phlpsong deleted the service_toggle_selection_issue branch February 29, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry23011 Jerry23011 Jerry23011 approved these changes

@tisfeng tisfeng tisfeng approved these changes

@NeverAgain11 NeverAgain11 Awaiting requested review from NeverAgain11

@choykarl choykarl Awaiting requested review from choykarl

@AkaShark AkaShark Awaiting requested review from AkaShark

@CanglongCl CanglongCl Awaiting requested review from CanglongCl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phlpsong @tisfeng @Jerry23011