bugfix: settings window display issue #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlpsong
requested review from
NeverAgain11,
choykarl,
tisfeng,
AkaShark,
CanglongCl and
Jerry23011
Jerry23011
previously approved these changes
Feb 17, 2024
tisfeng
requested changes
Feb 17, 2024
tisfeng
requested changes
Feb 17, 2024
Easydict/Feature/ViewController/Window/WindowManager/EZWindowManager.m
Outdated
Show resolved
Hide resolved
…gs window is not showing
tisfeng
approved these changes
Feb 17, 2024
AkaShark
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #362
also fixed the issue that uses the shortcut key
cmd+,to popup settings window while the query window is shown.