-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings to shortcuts #416
Add settings to shortcuts #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, I just got two issues:
- The colour pattern of the switch button is in default, so it is blacker than the pin icon on the right, can we customize it to match the colour of the pin icon?
- Do we want to add an option in settings to allow users disable the button or keep it there as an option
Co-authored-by: Tisfeng <[email protected]>
Co-authored-by: Tisfeng <[email protected]>
Co-authored-by: Tisfeng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This settings button looks like bigger than other quick link button. May be you can use resizeImage
make it better
EZOpenLinkButton *button = [[EZOpenLinkButton alloc] init];
NSImage *image = [NSImage imageWithSystemSymbolName:@"switch.2" accessibilityDescription:nil];
image = [image resizeToSize:CGSizeMake(16, 16)];
NSColor *tintColor = [NSColor mm_colorWithHexString:@"#C0C1C4"];
image = [image imageWithTintColor:tintColor];
button.image = image;
Fixed problem with setting button. |
Sounds reasonable, what do the rest of you think about this? |
I think grey is better. |
Agreed it! |
Ok, let's keep it grey. |
…hortcuts # Conflicts: # Easydict/Feature/Configuration/Configuration.swift # Easydict/Feature/Utility/Swift/Notification/Notification+Name.swift
This reverts commit e5d9dc4.
…hortcuts # Conflicts: # Easydict/Feature/Configuration/Configuration.swift
Looks good. |
Please continue to review. |
#354