Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service toggle issue after switch focus #424

Merged
merged 6 commits into from
Feb 25, 2024

Conversation

phlpsong
Copy link
Collaborator

close #423

@tisfeng
Copy link
Owner

tisfeng commented Feb 24, 2024

The code works, but it will cause this bug again #326 (comment)

@phlpsong
Copy link
Collaborator Author

The code works, but it will cause this bug again #326 (comment)

fixed.

@tisfeng
Copy link
Owner

tisfeng commented Feb 24, 2024

ok, looks good.

Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also fixed a bug where the toggle state is not updating after switching windows.

@tisfeng
Copy link
Owner

tisfeng commented Feb 25, 2024

Please review this PR, I will release a new version after merging it.

@tisfeng tisfeng merged commit 2888379 into tisfeng:dev Feb 25, 2024
5 checks passed
@phlpsong phlpsong deleted the service_toggle_issue branch February 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants