Language preference #440
Closed
Language preference #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choykarl
requested review from
tisfeng,
CanglongCl and
phlpsong
and removed request for
tisfeng and
CanglongCl
tisfeng
requested changes
Mar 4, 2024
|
This is a huge work, it does work indeed and the effect is very good. I originally thought that this feature only required switching languages within the application, then reloading the language bundle to achieve it, or restarting app in a programmed way 🥹 |
|
Can we move language option to here? 
|
tisfeng
reviewed
Mar 7, 2024
tisfeng
reviewed
Mar 7, 2024
# Conflicts: # Easydict/Feature/PerferenceWindow/EZSettingViewController.m # Easydict/NewApp/Utility/Extensions/QueryService+ConfigurableService/DeepLTranslate+ConfigurableService.swift # Easydict/NewApp/View/SettingView/Tabs/AboutTab.swift # Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift
tisfeng
requested changes
Mar 17, 2024
| @@ -29,6 +30,7 @@ | |||
| } | |||
| }, | |||
| "adjust_pop_button_origin" : { | |||
| "extractionState" : "stale", | |||
fixed~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#348