Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not close pinned window when clicking link button #462

Merged
merged 1 commit into from
Mar 20, 2024
Merged

perf: do not close pinned window when clicking link button #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Easydict/Feature/ViewController/View/CustomButton/EZLinkButton/EZOpenLinkButton.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ - (void)openURLWithQueryText:(NSString *)text {
// !!!: when using openURL, URL must has scheme, like https://
BOOL success = [[NSWorkspace sharedWorkspace] openURL:URL];
if (success) {
if (EZWindowManager.shared.floatingWindowType != EZWindowTypeMain) {
EZBaseQueryWindow *window = EZWindowManager.shared.floatingWindow;
// When opening a link, do not automatically close main window, or a pinned window.
if (!(window.windowType == EZWindowTypeMain || window.isPin)) {
[[EZWindowManager shared] closeFloatingWindow];
}
}
Expand Down