-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite OpenAI service with Swift #473
Conversation
There are no feature changes in this PR, just a rewrite of the OpenAI service using Swift and removing the old objc code. Other changes:
|
There seems to be something wrong with CI, can anyone help take a look? |
@phlpsong I didn't change the configuration of custom OpenAI, I don't know why its interface changed to be the same as OpenAI. I debug found that it will call |
I think the root cause is the change of inheritance of OpenAIService and CustomOpenAIService, currently, CustomOpenAIService inherits from OpenAIService and they both implement Maybe the simple approach is to create a base class like before, and make the subclass conform to |
@phlpsong ok, thank you for your answer, I will check it later. |
I added a |
I just found out that Xcode 15.3 could fix this. Currently, CI uses 15.1. |
The system images of CI and Xcode versions are usually a bit outdated. As long as they run without issues, we can temporarily keep them until adapting to the new major updates. |
Sure, let's keep the current package configuration utils stable. |
Please review this PR 🥹 |
All fixed, please continue to review. |
Co-authored-by: Phillip Song <[email protected]>
Co-authored-by: Phillip Song <[email protected]>
Co-authored-by: Phillip Song <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #291