Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add action to replace newline with space #483

Merged
merged 8 commits into from
Apr 2, 2024
Merged

feat: add action to replace newline with space #483

merged 8 commits into from
Apr 2, 2024

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Mar 31, 2024

Jerry23011
Jerry23011 reviewed Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add this option in Settings?

@tisfeng
Copy link
Owner Author

tisfeng commented Apr 1, 2024

No, this action is usually only needed in some special cases, so I don't think we need to add an extra option.

@tisfeng tisfeng requested a review from Jerry23011 April 1, 2024 15:20
@tisfeng tisfeng merged commit 3d5ea5b into dev Apr 2, 2024
5 checks passed
@tisfeng tisfeng deleted the replace-newline-with-space branch April 2, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlpsong phlpsong phlpsong approved these changes

@Jerry23011 Jerry23011 Jerry23011 approved these changes

@NeverAgain11 NeverAgain11 Awaiting requested review from NeverAgain11

@choykarl choykarl Awaiting requested review from choykarl

@AkaShark AkaShark Awaiting requested review from AkaShark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisfeng @Jerry23011 @phlpsong