Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tool tips #500

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Fix tool tips #500

merged 13 commits into from
Apr 11, 2024

Conversation

AkaShark
Copy link
Collaborator

@AkaShark AkaShark commented Apr 9, 2024

close #498

Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it works well.

I'm not familiar with SwiftUI, please continue to review to ensure the code is elegant.

@AkaShark AkaShark requested review from tisfeng and phlpsong April 9, 2024 15:15
phlpsong
phlpsong previously approved these changes Apr 9, 2024
Copy link
Collaborator

@phlpsong phlpsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tisfeng
Copy link
Owner

tisfeng commented Apr 10, 2024

I improved the code, please continue to review.

@tisfeng tisfeng requested a review from phlpsong April 11, 2024 15:18
@tisfeng tisfeng merged commit 84458c0 into tisfeng:dev Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants