Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not hide model button when loading #516

Merged
merged 13 commits into from
Apr 20, 2024
Merged

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Apr 18, 2024

iShot_2024-04-18_22.01.29.mp4

@phlpsong
Copy link
Collaborator

Looks good, but I found some layout problems need to take a look:

  1. Model text switched to some other model name when pointer hover on it
Screen.Recording.2024-04-18.at.23.00.15.mov
  1. The warning image has an overlap issue with the model selection button
Screenshot 2024-04-18 at 23 01 46
  1. The loading icon is out of the bounds of the area and overlaps with the arrow image, it could be more obvious if service name is longer
Screen.Recording.2024-04-18.at.23.02.00.mov

@tisfeng
Copy link
Owner Author

tisfeng commented Apr 19, 2024

All the issues have been resolved.

I increased the minimum width of the window a bit, limited the length of custom OpenAI names, and also limited the maximum length of the service name label and model button.

image

@tisfeng tisfeng requested a review from CanglongCl April 19, 2024 13:40
@tisfeng
Copy link
Owner Author

tisfeng commented Apr 19, 2024

Show service name label and model button width based on window width ratio, if window has enough width, they can be shown fully.

image

@phlpsong
Copy link
Collaborator

Screen.Recording.2024-04-20.at.17.49.25.mov

This issue still exists if you press the modal name instead of hovering over it.

@tisfeng
Copy link
Owner Author

tisfeng commented Apr 20, 2024

ok, fixed.

EZButton is a control I wrote casually at that time. This is my first time writing a macOS application, and many codes were not very good 😥

Although the code is bad, there is no need to optimize it. Let's rewrite it with SwiftUI later.

@tisfeng tisfeng merged commit 8fb1440 into dev Apr 20, 2024
5 checks passed
@tisfeng tisfeng deleted the do-not-hide-model-button branch April 20, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants