Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve local language #530

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: improve local language #530

merged 2 commits into from
May 2, 2024

Conversation

choykarl
Copy link
Collaborator

@choykarl choykarl commented May 2, 2024

@choykarl choykarl requested a review from phlpsong May 2, 2024 10:14
phlpsong
phlpsong approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@phlpsong phlpsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisfeng tisfeng merged commit 1ae0164 into tisfeng:dev May 2, 2024
5 checks passed
@tisfeng tisfeng mentioned this pull request May 4, 2024
Closed
6 tasks
@choykarl choykarl deleted the fix_localized branch July 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlpsong phlpsong phlpsong approved these changes

@Jerry23011 Jerry23011 Jerry23011 approved these changes

@NeverAgain11 NeverAgain11 Awaiting requested review from NeverAgain11

@tisfeng tisfeng Awaiting requested review from tisfeng

@AkaShark AkaShark Awaiting requested review from AkaShark

@CanglongCl CanglongCl Awaiting requested review from CanglongCl

@Kyle-Ye Kyle-Ye Awaiting requested review from Kyle-Ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@choykarl @Jerry23011 @phlpsong @tisfeng