fix: apple dict webView layout is wrong #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlpsong
reviewed
Oct 23, 2024
Easydict/objc/ViewController/View/WordResultView/EZWordResultView.m
Outdated
Show resolved
Hide resolved
phlpsong
reviewed
Oct 23, 2024
Easydict/objc/ViewController/View/WordResultView/EZWordResultView.m
Outdated
Show resolved
Hide resolved
Easydict/objc/ViewController/View/WordResultView/EZWordResultView.m
Outdated
Show resolved
Hide resolved
Easydict/objc/ViewController/View/WordResultView/EZWordResultView.m
Outdated
Show resolved
Hide resolved
phlpsong
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #698
Currently, the layout of the webView is incorrect, which causes the webView to be obstructed and unable to display the results of the Apple Dictionary.
It looks like there are many changes in the code, but in reality, only one conditional statement was added: when there is an
HTMLString, only the webView is displayed, and the other layouts remain unchanged.