Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add window configuration to allow hiding the text input and language selection bar #703

Merged
merged 10 commits into from
Oct 29, 2024

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Oct 26, 2024

Close #700

image

@Jerry23011
Copy link
Collaborator

Love the feature.

I'm wondering why the two toggles are placed in the Service settings.

After selecting a service, the toggles are "hidden" until clicking on an option in the top bar. This may be a bit inconvenient.

@tisfeng
Copy link
Owner Author

tisfeng commented Oct 27, 2024

I know, but I can't find a suitable place to put it.

Window configuration is only related to the window type and involves multiple window types, similar to the UI of the Service configuration. I don't want to add a separate tab, so I've decided to reuse the Service configuration.

Perhaps the tab title can be changed to "Window Service" to show its relevance to both window and service configuration.

If you have a better UI design, please let me know.

@Jerry23011
Copy link
Collaborator

Window configuration is only related to the window type and involves multiple window types

I see, didn't realize the configs are separate for different window types.

Then is it possible to add a "go back" or "go home" button somewhere to go back to the service settings. Or is there a way to deselect a service? For now I can only do that by switching a new window type, which is not very intuitive.

@tisfeng
Copy link
Owner Author

tisfeng commented Oct 27, 2024

Sounds good, I added a back button that returns from service configuration to window configuration when clicked.

image

@tisfeng tisfeng merged commit 335937f into dev Oct 29, 2024
5 checks passed
@tisfeng tisfeng deleted the feat-hide-input branch October 29, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants