Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Localizable.xcstrings #704

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Update Localizable.xcstrings #704

merged 3 commits into from
Oct 28, 2024

Conversation

Svec-Tomas
Copy link
Contributor

Improvement of the Slovak translation

Improvement of the Slovak translation
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Svec-Tomas, Thank you for your first PR contribution 🎉 Svec-Tomas

Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Easydict/App/Localizable.xcstrings Outdated Show resolved Hide resolved
Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @Svec-Tomas

@tisfeng tisfeng merged commit adea8ad into tisfeng:main Oct 28, 2024
5 checks passed
@tisfeng
Copy link
Owner

tisfeng commented Oct 28, 2024

@Svec-Tomas Thanks for your PR.

We usually develop on the dev branch, which is ahead of the main branch. Currently, it has added some new localized texts. If you have time, please help us check the Slovak localization of the dev branch.

For the next PR, please develop and submit PR based on dev.

@Svec-Tomas
Copy link
Contributor Author

Hi @tisfeng

I primarily use GitHub for the purpose of localizing applications into my native language. I truly value it when developers make the translation process as smooth as possible, for instance by providing support for other translation tools or offering detailed instructions. Unfortunately, I'm unfamiliar with the concept of a dev branch. As for my translation workflow, I avoid using Xcode due to its complexity. I've discovered more intuitive tools that are both lightweight and easy to use.

@Jerry23011
Copy link
Collaborator

Unfortunately, I'm unfamiliar with the concept of a dev branch

@Svec-Tomas This is not about what tools you use. When you download (or pull) xcstring from GitHub, please use the dev branch: https://github.com/tisfeng/Easydict/tree/dev

I understand that Xcode is heavy, and git can be complicated. You are doing an incredible job learning to PR on GitHub, feel free to use whatever tool you want. We are just here giving you suggestions to best align with our development goals.

@Svec-Tomas
Copy link
Contributor Author

I have went through all translations and fixed some translations. Hopefully this time everything is OK. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants