Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre validate service #727

Merged
merged 12 commits into from
Nov 21, 2024
Merged

Conversation

AkaShark
Copy link
Collaborator

closed #714

@AkaShark AkaShark changed the title pre validate service feat: pre validate service Nov 18, 2024
@CanglongCl
Copy link
Collaborator

@AkaShark Hi I made some changes to your branch. Now while user click the toggle, it will be turned into a ProgressView individually. Error message alert is also implemented.

@AkaShark
Copy link
Collaborator Author

AkaShark commented Nov 19, 2024

@AkaShark Hi I made some changes to your branch. Now while user click the toggle, it will be turned into a ProgressView individually. Error message alert is also implemented.

@CanglongCl Thank you for your commit! As someone new to SwiftUI, your code helps me learn more, and it improves this feature significantly.

@AkaShark AkaShark requested a review from tisfeng November 19, 2024 14:33
@tisfeng
Copy link
Owner

tisfeng commented Nov 19, 2024

I improved the UI, aligning the ProgressView and Toggle 0b51d9a

Before

image

Now

image

Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the new localizations, we need to add translations in English, Simplified Chinese, Traditional Chinese, and Slovak.

We just need to ensure that the translations in Chinese and English are correct. As for other languages, such as Slovak, translation tools can be used.

I usually use Cursor for auto-completion, and later there will be users familiar with that language to proofread #708 (comment)

image image

@tisfeng
Copy link
Owner

tisfeng commented Nov 19, 2024

I'm considering removing the en-CA localization because it's almost the same as en, and we're not familiar with it. It's not worth spending time to differentiate between them.

Initially, we added en-CA just to provide users with a localization example #231. Moreover, there's now a better Slovak localization example #668.

@AkaShark
Copy link
Collaborator Author

AkaShark commented Nov 19, 2024

For the new localizations, we need to add translations in English, Simplified Chinese, Traditional Chinese, and Slovak.

We just need to ensure that the translations in Chinese and English are correct. As for other languages, such as Slovak, translation tools can be used.

I usually use Cursor for auto-completion, and later there will be users familiar with that language to proofread #708 (comment)

image image

That seems like a good way.

@tisfeng tisfeng requested a review from Copilot November 21, 2024 12:53

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • Easydict/App/Localizable.xcstrings: Language not supported
  • Easydict/Swift/View/SettingView/Tabs/TabView/ServiceTab.swift: Language not supported
Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tisfeng tisfeng merged commit c18a7a1 into tisfeng:dev Nov 21, 2024
4 checks passed
@Jerry23011
Copy link
Collaborator

I'm considering removing the en-CA localization because it's almost the same as en, and we're not familiar with it. It's not worth spending time to differentiate between them.

Initially, we added en-CA just to provide users with a localization example #231. Moreover, there's now a better Slovak localization example #668.

+1 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants