-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftUI window and list/window style #739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I removed StaticWindows, and replaced the AppKit window with SwiftUI window management. Referring to this #716 (comment), I tried to unify the style of the acknowledgment navigation window, although there are still some differences. If anyone can further improve it, feel free to modify the code. ![]() ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (9)
- Easydict.xcodeproj/project.pbxproj: Language not supported
- Easydict/App/EasydictApp.swift: Language not supported
- Easydict/App/Localizable.xcstrings: Language not supported
- Easydict/Swift/Utility/Constants/Constants.swift: Language not supported
- Easydict/Swift/Utility/Extensions/View/View+Builder.swift: Language not supported
- Easydict/Swift/View/AcknowListView/AcknowListView.swift: Language not supported
- Easydict/Swift/View/SettingView/SettingView.swift: Language not supported
- Easydict/Swift/View/SettingView/Tabs/TabView/AboutTab.swift: Language not supported
- Easydict/Swift/View/Windows/StaticWindows.swift: Language not supported
The var body: some View {
NavigationStack {
AcknowListSwiftUIView(acknowList: acknowList)
.listStyle(.sidebar)
}
.hideWindowToolbarBackground()
.thickMaterialWindowBackground()
} If this is enough for this project's customization, we can stick with it. But if you want further customization, you can also give my AcknowKit a try (Or just copy and paste the code). (Does not support auto discovery yet.) Examples: ![]() ![]() ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the StaticWindows change. And there is a UI issue I think we should fix before the merge. (Hide nav bar cause UI overlap when we scroll the content up in Acknow Window)
Co-authored-by: Kyle <[email protected]>
ok, I have removed The UI of AcknowKit looks nice, I will try it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From #716 (comment)