Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM GC backend #355

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open

WASM GC backend #355

wants to merge 60 commits into from

Conversation

eliotmoss
Copy link
Contributor

Fix batch of changes being submitted for comment. Work ends essentially just after the point where mtables are processed to obtain function table information.

eliotmoss and others added 11 commits November 18, 2024 13:39
@eliotmoss
Small fix to the aeneas script to make it a little more robust
61486a1 
to weird setting by people like me
@eliotmoss
Merge branch 'master' of github.com:eliotmoss/virgil
1c90622 
Should be a plain merge ...
@eliotmoss
Merge branch 'master' of github.com:eliotmoss/virgil
a5aae35 
Should be an ordinary merge
@eliotmoss
Work to date on the Wasm GC beck end. Will continue this work on this…
b809701 
… branch.
@eliotmoss
Merge branch 'master' into wasm_gc_backend_PR
fcbdc50
@titzer
[readonly] First tests for readonly arrays/ranges (titzer#356)
006f271
@titzer
[readonly] Check for readonly assignments and allow basic subsumption (…
1a13e35 
…titzer#357)
@titzer
[readonly] Add first execution tests for read-only arrays (titzer#358)
c63e78a
@titzer
[readonly] Add more execution tests (titzer#359)
1dd55b8
@titzer
[readonly] Fix casts and add tests with ranges (titzer#360)
b43df73
@titzer
Fix return type of Pointer.atUnboxedField tests (titzer#361)
b2ba936
titzer
titzer reviewed Feb 26, 2025
View reviewed changes
Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments.

aeneas/src/wasm/WasmCommon.v3 Outdated
@@ -0,0 +1,230 @@
// Copyright 2016 Google Inc. All rights reserved.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright notice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to add: Eliot Moss 2024-2025. If I should be using something different, let me know ...

titzer and others added 18 commits February 26, 2025 19:01
@titzer
[test] Add failing unboxing test
52bb24a
@titzer
[unbox] Fix folding of if-cascade (titzer#362)
8ada887
@titzer
Inline class methods (titzer#363)
91f2b47
@titzer
[opt] Constant-fold monomorphic variant allocations (titzer#364)
511056f
@titzer
[unboxing] Use List<IrField> in Pointer.atUnboxedField instead of IrS…
ce68ae4 
…pec (titzer#365)
@titzer
[opt] Allow more inlining of class methods (titzer#366)
6c0f39b
@titzer
[opt] Inline constructor calls and remove dead allocations (titzer#367)
1952c7d
@eliotmoss
Addressing comments on recent commit.
916669d
@eliotmoss
Merge branch 'wasm_gc_backend_PR' of github.com:eliotmoss/virgil into…
fbedc2d 
… wasm_gc_backend_PR

Should be an ordinary merge of upstream changes.
@titzer
[ideas] Add some ideas on Maybe types and encodings
3d0da16
@titzer
[ideas] Add OpenEnum ideas
65f0893
@titzer
OpenTypeCases.v3
d3adc98
@titzer
[ideas] Update InitSyntax and add Macros
e096390
@titzer
Use NormFlattener in Normalization (titzer#369)
e4f806c
@titzer
Use NormFlattener in VariantSolver (titzer#370)
7537264
@titzer
Use RaField.normIndices and RaField.origIndices for unboxed variants (t…
bd5a2ec 
…itzer#371)
@MSMazaya
Add access syscall number to LinuxConst (titzer#372)
60b2067
@titzer
[ideas] Convert InitSyntax.v3 to more JSON-like syntax
8b9f0e3
titzer and others added 30 commits March 9, 2025 15:20
@titzer
[test] Move test/core tests that use variants to test/variants (titze…
e64483e 
…r#377)
@MSMazaya
Add x86-64 syscall numbers to LinuxConst (titzer#374)
01f78fa
@titzer
[test] Prune test/fail (titzer#378)
1da7ea3
@titzer
[doc] Add item for representing closures with variants
bdfae00
@titzer
[doc] Add item to enable register coalescing
597b2de
@eliotmoss
Seem to be writing at least one good type section, including a recurs…
a33de5b 
…ion group
@eliotmoss
jvm tests of apps failed with System.out/System.err calls around
72349de
@eliotmoss
Trivial correction in a comment to force CI to run again
4eebdcd
@eliotmoss
Work to date on the Wasm GC beck end. Will continue this work on this…
6460bb2 
… branch.

Rebasing in hope of fixing CI errors
@eliotmoss
Addressing comments on recent commit.
1025375 
Continuing rebase
@eliotmoss
Seem to be writing at least one good type section, including a recurs…
c7a08ee 
…ion group
@eliotmoss
jvm tests of apps failed with System.out/System.err calls around
b01f78c
@eliotmoss
Trivial correction in a comment to force CI to run again
ac60c03
@eliotmoss
Merge branch 'wasm_gc_backend_PR' of github.com:eliotmoss/virgil into…
f39f96a 
… wasm_gc_backend_PR
@eliotmoss
Last (vestiges) of the dropped save-ra option removed
f2d0a73
@eliotmoss
Should have built locally before committing :-(
d271633
@eliotmoss
Work to date on the Wasm GC beck end. Will continue this work on this…
08eb1ce 
… branch.

Continuing to rebase
@eliotmoss
Addressing comments on recent commit.
a51b352 
Continuing rebase
@eliotmoss
Seem to be writing at least one good type section, including a recurs…
669d136 
…ion group

Continuing rebase
@eliotmoss
Last (vestiges) of the dropped save-ra option removed
2503add
@eliotmoss
Trying again for a "clean" rebase"
2ef84e4
@eliotmoss
Merge branch 'wasm_gc_backend_PR' of github.com:eliotmoss/virgil into…
8b4076c 
… wasm_gc_backend_PR

One last (?) conflict
@eliotmoss
Starting to write some tests for wasmgc
d64fc0f
@eliotmoss
This do-nothing script keeps the test runners happy for now
668e57b
@eliotmoss
Fixed lack of tag field for classes and lack of receiver for class me…
2e321e6 
…thods; add more type table tracing support
@eliotmoss
More tests, better debug support
e151ce4
@eliotmoss
Move Wasm heap type printing to render methods; improve type section …
056f974 
…printing
@eliotmoss
Progress on functions/tables part, including printing
6b32a86
@eliotmoss
Interim commit; in the middle of figuring out generating mtables for …
e0e7dc5 
…WASM GC
@eliotmoss
Refactored to pull ObjectSystem op lowering into a separate class, wh…
4e14bd6 
…ich a target can override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titzer titzer titzer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliotmoss @titzer @MSMazaya