Improve scripts (pull request) #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to weird setting by people like me
Should be a plain merge ...
Should be an ordinary merge
Remove visitor
Fixing so things should build (this code has been changed in the actual WIP PR for the WASM GC target).
More edits to make this buildable
…adjusting it as well
|
I struggled to find why the wasm builds were failing, but finally got it. I realize now that there are more scripts out there that could be reworked, but I think I'll stop for now since I think most of them are ci scripts so usually run in a more controlled environment. |
… folding and obviates inlining (titzer#375)
|
Ben, you mentioned having made comments, but I don't see any. Maybe you looked at the old PR? |
Fixing so things should build (this code has been changed in the actual WIP PR for the WASM GC target).
More edits to make this buildable
…adjusting it as well
Getting right collection of stuff into this PR
… improve_scripts_PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chanfge scripts to protect against user redefinition of cd, etc.