Merge pull request #269 from tjek/mr/incito_stop_prop

Incito: Stop propagation when clicking links and carousel arrows
tjek · Dec 9, 2024 · 40ce139 · 40ce139
2 parents 18152a9 + 2014d01
commit 40ce139
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/lib/incito-browser/incito.ts b/lib/incito-browser/incito.ts
@@ -812,6 +812,8 @@ export default class Incito extends MicroEvent<{
             const link = linkEl ? linkEl.dataset.link : null;
 
             if (isDefinedStr(link)) {
+                e.stopPropagation();
+
                 window.open(link!, '_blank');
             }
 
@@ -821,6 +823,8 @@ export default class Incito extends MicroEvent<{
                 const scrollLeft = carouselEl.scrollLeft;
 
                 if (carouselPrevEl) {
+                    e.stopPropagation();
+
                     const newScrollLeft = scrollLeft - clientWidth;
 
                     if (newScrollLeft < 0) {
@@ -835,6 +839,8 @@ export default class Incito extends MicroEvent<{
                         });
                     }
                 } else if (carouselNextEl) {
+                    e.stopPropagation();
+
                     const newScrollLeft = scrollLeft + clientWidth;
 
                     if (newScrollLeft >= scrollWidth) {