fix(publish): Handle binary diff (#252)

tjek · Sep 17, 2024 · e4f22a8 · e4f22a8
1 parent 3631bc7
commit e4f22a8
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -43,10 +43,13 @@
         "@aws-sdk/client-cloudfront": "^3.651.1",
         "@aws-sdk/client-s3": "^3.651.1",
         "@playwright/browser-chromium": "^1.47.1",
+        "@types/diff": "^5.2.2",
         "@types/jest": "^29.5.13",
         "@types/mustache": "^4.2.5",
         "@types/nib": "^1.1.2",
         "@types/node": "^18.16.12",
+        "@types/recursive-readdir": "^2.2.4",
+        "@types/semver": "^7.5.8",
         "@types/stylus": "^0.48.43",
         "@typescript-eslint/eslint-plugin": "^8.6.0",
         "@typescript-eslint/parser": "^8.6.0",

diff --git a/publish-npm.mjs b/publish-npm.mjs
@@ -238,16 +238,18 @@ const printDiffPackage = (diffObj) =>
 
 async function publish() {
     console.clear();
-    if (DRY_RUN) console.info('Dry run! 🌵');
-
-    const gitInd = ora(`Git: Checking working tree`).start();
-    if (await run('git', ['status', '--porcelain'])) {
-        gitInd.fail(
-            'Git: Working tree dirty. Please resolve any changes before publishing.'
-        );
-        return;
+    if (DRY_RUN) {
+        console.info('Dry run! 🌵');
+    } else {
+        const gitInd = ora(`Git: Checking working tree`).start();
+        if (await run('git', ['status', '--porcelain'])) {
+            gitInd.fail(
+                'Git: Working tree dirty. Please resolve any changes before publishing.'
+            );
+            return;
+        }
+        gitInd.succeed(`Git: Working tree clean`);
     }
-    gitInd.succeed(`Git: Working tree clean`);
 
     const commithash = execSync('git rev-parse --short HEAD', {
         encoding: 'utf8'
@@ -301,6 +303,9 @@ async function publish() {
                 (memo, diff) => {
                     if (diff) {
                         memo.changeCount++;
+                        if (diff.includes('Binary files differ')) {
+                            return memo;
+                        }
                         const [
                             {
                                 hunks: [hunk]