Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Incito): Handle non-body scroll container #236

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

klarstrup
Copy link
Member

No description provided.

@klarstrup klarstrup requested a review from mortenbo June 7, 2024 11:22
@mortenbo
Copy link
Member

@jrlarano @klarstrup How can we get rid of getScrollContainer? Can't we make it so that the viewer uses by default but if the SDK uses another scroll container, it has to pass it as a param?

@jrlarano
Copy link
Contributor

I'm not sure I get the purpose of this. Is this for removing the global scroll that we can see here?
image

If so, they can add this to their integration code data-component-publication-disable-global-scrollbar="true"
https://github.com/tjek/tjek-js-sdk/blob/develop/lib/kits/core-ui/incito-publication.ts#L226...#L233

@klarstrup
Copy link
Member Author

No, this is to fix IntersectionObserver lazy loading thresholds because they won't trigger ahead of time if the scroll container is another than the one being observed (body by default)

@klarstrup
Copy link
Member Author

@jrlarano @klarstrup How can we get rid of getScrollContainer? Can't we make it so that the viewer uses by default but if the SDK uses another scroll container, it has to pass it as a param?

Uses what by default? 😅

@mortenbo
Copy link
Member

I think GitHub stripped my comment. I wrote html tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants