Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incito: Stop propagation when clicking links and carousel arrows #269

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Incito: Stop propagation when clicking links and carousel arrows #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/incito-browser/incito.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,8 @@ export default class Incito extends MicroEvent<{
const link = linkEl ? linkEl.dataset.link : null;

if (isDefinedStr(link)) {
e.stopPropagation();

window.open(link!, '_blank');
}

Expand All @@ -821,6 +823,8 @@ export default class Incito extends MicroEvent<{
const scrollLeft = carouselEl.scrollLeft;

if (carouselPrevEl) {
e.stopPropagation();

const newScrollLeft = scrollLeft - clientWidth;

if (newScrollLeft < 0) {
Expand All @@ -835,6 +839,8 @@ export default class Incito extends MicroEvent<{
});
}
} else if (carouselNextEl) {
e.stopPropagation();

const newScrollLeft = scrollLeft + clientWidth;

if (newScrollLeft >= scrollWidth) {
Expand Down
Loading