Add tests to catch colon in channel name regression.

tjni · Nov 22, 2024 · 17e8b80 · 17e8b80
1 parent b014abd
commit 17e8b80
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/tests/test_async.py b/tests/test_async.py
@@ -139,7 +139,13 @@ async def test_write_and_read_pending_writes_and_sends(self) -> None:
 
             assert result.checkpoint["pending_sends"] == ["w3v"]
 
-    @pytest.mark.parametrize("channel_values", [{"channel1": "channel1v"}, {}])
+    @pytest.mark.parametrize(
+        "channel_values",
+        [
+            {"channel1": "channel1v"},
+            {},  # to catch regression reported in #10
+        ],
+    )
     async def test_write_and_read_channel_values(
         self, channel_values: dict[str, Any]
     ) -> None:
@@ -155,7 +161,10 @@ async def test_write_and_read_channel_values(
             chkpnt["id"] = "4"
             chkpnt["channel_values"] = channel_values
 
-            newversions: ChannelVersions = {"channel1": 1}
+            newversions: ChannelVersions = {
+                "channel1": 1,
+                "channel:with:colon": 1,  # to catch regression reported in #9
+            }
             chkpnt["channel_versions"] = newversions
 
             await saver.aput(config, chkpnt, {}, newversions)

diff --git a/tests/test_sync.py b/tests/test_sync.py
@@ -138,7 +138,13 @@ def test_write_and_read_pending_writes_and_sends(self) -> None:
 
             assert result.checkpoint["pending_sends"] == ["w3v"]
 
-    @pytest.mark.parametrize("channel_values", [{"channel1": "channel1v"}, {}])
+    @pytest.mark.parametrize(
+        "channel_values",
+        [
+            {"channel1": "channel1v"},
+            {},  # to catch regression reported in #10
+        ],
+    )
     def test_write_and_read_channel_values(
         self, channel_values: dict[str, Any]
     ) -> None:
@@ -154,7 +160,10 @@ def test_write_and_read_channel_values(
             chkpnt["id"] = "4"
             chkpnt["channel_values"] = channel_values
 
-            newversions: ChannelVersions = {"channel1": 1}
+            newversions: ChannelVersions = {
+                "channel1": 1,
+                "channel:with:colon": 1,  # to catch regression reported in #9
+            }
             chkpnt["channel_versions"] = newversions
 
             saver.put(config, chkpnt, {}, newversions)