Patch openssl crates against CVE-2025-24898 #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I performed a differential code review of the changed crates: With The crate changes look good and I approve of them from a dependency reviewer standpoint. |
mark-nesbitt
approved these changes
Feb 7, 2025
r-n-o
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
Adopt new
opensslcrate versions to patch CVE-2025-24898.From what I can tell, we're not directly making use of the affected
ssl::select_next_proto, but one of the dependencies inqos_enclavemay do so. Switch to a patched version to be on the safe side.How I Tested These Changes
Needs regression testing.
Pre merge check list